Skip to content

chore(bigquery): Remove unused legacy region tag for delete transfer #13764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
amcolin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(bigquery): Remove unused legacy region tag for delete transfer #13764

amcolin wants to merge 1 commit into from
+0 −4

Conversation

@amcolin
Copy link

@amcolin amcolin commented Jan 27, 2026 •
edited
Loading

Description

Fixes Internal: b/470266066

Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.

Checklist

@product-auto-label product-auto-label bot added api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples. labels Jan 27, 2026
@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Jan 27, 2026

Summary of Changes

Hello @amcolin, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on code maintenance within the bigquery-datatransfer Python samples. It specifically removes an outdated and unused region tag from the delete_config function, enhancing the clarity and tidiness of the codebase without introducing any functional changes.

Highlights

  • Code Cleanup: Removed unused [START] and [END] region tags associated with bigquerydatatransfer_delete_transfer from the delete_config function in manage_transfer_configs.py.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Jan 27, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes unused legacy region tags from the delete_config function. The change is correct and aligns with the goal of cleaning up the snippets. I've provided one suggestion to further simplify the delete_config function, taking advantage of the fact that it's no longer a documentation snippet, which improves code clarity and removes now-unnecessary boilerplate.

@iennae iennae marked this pull request as ready for review January 27, 2026 22:07
@iennae iennae requested review from a team as code owners January 27, 2026 22:07
@snippet-bot
Copy link

snippet-bot bot commented Jan 27, 2026 •
edited
Loading

Here is the summary of possible violations 😱

Details

There are 2 possible violations for removing region tag in use.

The end of the violation section. All the stuff below is FYI purposes only.

You are about to delete the following sample browser pages.

Here is the summary of changes.

You are about to delete 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@Alan5142 Alan5142 added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 28, 2026
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 28, 2026
@amcolin amcolin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2026
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 28, 2026
@amcolin amcolin added the snippet-bot:force-run Force snippet-bot runs its logic label Jan 29, 2026
@snippet-bot snippet-bot bot removed the snippet-bot:force-run Force snippet-bot runs its logic label Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

api: bigquery Issues related to the BigQuery API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amcolin @Alan5142 @kokoro-team